netlink: specs: ethtool: fix module EEPROM input/output arguments
authorJakub Kicinski <kuba@kernel.org>
Wed, 30 Jul 2025 17:21:37 +0000 (10:21 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 31 Jul 2025 17:57:02 +0000 (10:57 -0700)
Module (SFP) eeprom GET has a lot of input params, they are all
mistakenly listed as output in the spec. Looks like kernel doesn't
output them at all. Correct what are the inputs and what the outputs.

Reported-by: Duo Yi <duo@meta.com>
Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250730172137.1322351-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/netlink/specs/ethtool.yaml

index 1063d5d32fea2557a40dfcbad182b83efa0a62a2..1bc1bd7d33c2cdb9ddf49cf9743629cfeff10fdc 100644 (file)
@@ -2342,9 +2342,6 @@ operations:
 
       do: &module-eeprom-get-op
         request:
-          attributes:
-            - header
-        reply:
           attributes:
             - header
             - offset
@@ -2352,6 +2349,9 @@ operations:
             - page
             - bank
             - i2c-address
+        reply:
+          attributes:
+            - header
             - data
       dump: *module-eeprom-get-op
     -