drm/amdgpu: Fix amdgpu_userq_wait_ioctl() warn missing error code 'r'
authorArvind Yadav <Arvind.Yadav@amd.com>
Thu, 8 May 2025 05:58:18 +0000 (11:28 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 13 May 2025 13:21:56 +0000 (09:21 -0400)
To resolve the warning regarding the missing error code 'r' in
amdgpu_userq_wait_ioctl(), assign the value 'r = -EINVAL'.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202505080458.rnV8YfiY-lkp@intel.com/
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Reviewed-by: Sunil Khatri <sunil.khatri@amd.com>
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c

index 029cb24c28b3801c0d1f54e24ada587725caf00f..58ef5afba82ef0dfd4d2a3089ea64e9353015153 100644 (file)
@@ -859,8 +859,10 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data,
                num_fences = dma_fence_dedup_array(fences, num_fences);
 
                waitq = idr_find(&userq_mgr->userq_idr, wait_info->waitq_id);
-               if (!waitq)
+               if (!waitq) {
+                       r = -EINVAL;
                        goto free_fences;
+               }
 
                for (i = 0, cnt = 0; i < num_fences; i++) {
                        struct amdgpu_userq_fence_driver *fence_drv;