net: dsa: remove calls to genphy_config_init
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 17 Aug 2019 10:29:54 +0000 (12:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Aug 2019 19:34:50 +0000 (12:34 -0700)
Supported PHY features are either auto-detected or explicitly set.
In both cases calling genphy_config_init isn't needed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/port.c

index f071acf2842bdb8b9b29eb521d00bf61b5dc8ba2..f75301456430bdf5af333c5e870a5ee5fce5761b 100644 (file)
@@ -538,10 +538,6 @@ static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)
                return PTR_ERR(phydev);
 
        if (enable) {
-               err = genphy_config_init(phydev);
-               if (err < 0)
-                       goto err_put_dev;
-
                err = genphy_resume(phydev);
                if (err < 0)
                        goto err_put_dev;
@@ -589,7 +585,6 @@ static int dsa_port_fixed_link_register_of(struct dsa_port *dp)
                mode = PHY_INTERFACE_MODE_NA;
        phydev->interface = mode;
 
-       genphy_config_init(phydev);
        genphy_read_status(phydev);
 
        if (ds->ops->adjust_link)