drm/amd/powerplay: fix variable type errors in smu_v11_0_setup_pptable
authorKevin Wang <kevin1.wang@amd.com>
Mon, 19 Aug 2019 15:38:02 +0000 (23:38 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Aug 2019 22:30:45 +0000 (17:30 -0500)
fix size type errors, from uint32_t to uint16_t.
it will cause only initializes the highest 16 bits in
smu_get_atom_data_table function.

bug report:
This fixes the following static checker warning.
        drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:390 smu_v11_0_setup_pptable()
        warn: passing casted pointer '&size' to 'smu_get_atom_data_table()' 32 vs 16.

Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/smu_v11_0.c

index 5fde5cf65b4240a7428e3c89be0dabc0ea12902f..3ac061a3c3c5a2fcff9e6c31914a8394fe93dc4d 100644 (file)
@@ -327,6 +327,7 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu)
        const struct smc_firmware_header_v1_0 *hdr;
        int ret, index;
        uint32_t size;
+       uint16_t atom_table_size;
        uint8_t frev, crev;
        void *table;
        uint16_t version_major, version_minor;
@@ -354,10 +355,11 @@ static int smu_v11_0_setup_pptable(struct smu_context *smu)
                index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
                                                    powerplayinfo);
 
-               ret = smu_get_atom_data_table(smu, index, (uint16_t *)&size, &frev, &crev,
+               ret = smu_get_atom_data_table(smu, index, &atom_table_size, &frev, &crev,
                                              (uint8_t **)&table);
                if (ret)
                        return ret;
+               size = atom_table_size;
        }
 
        if (!smu->smu_table.power_play_table)