watchdog: xen_wdt: Use 'dev' instead of dereferencing it repeatedly
authorGuenter Roeck <linux@roeck-us.net>
Wed, 10 Apr 2019 16:27:50 +0000 (09:27 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:33 +0000 (21:02 +0200)
Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/xen_wdt.c

index f1c016d015b3bff4297ce7d245c92f89c14239a5..6c1ca1f31cbcdcf7732262686323b8a99ad50e0c 100644 (file)
@@ -122,35 +122,35 @@ static struct watchdog_device xen_wdt_dev = {
 
 static int xen_wdt_probe(struct platform_device *pdev)
 {
 
 static int xen_wdt_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct sched_watchdog wd = { .id = ~0 };
        int ret = HYPERVISOR_sched_op(SCHEDOP_watchdog, &wd);
 
        if (ret == -ENOSYS) {
        struct sched_watchdog wd = { .id = ~0 };
        int ret = HYPERVISOR_sched_op(SCHEDOP_watchdog, &wd);
 
        if (ret == -ENOSYS) {
-               dev_err(&pdev->dev, "watchdog not supported by hypervisor\n");
+               dev_err(dev, "watchdog not supported by hypervisor\n");
                return -ENODEV;
        }
 
        if (ret != -EINVAL) {
                return -ENODEV;
        }
 
        if (ret != -EINVAL) {
-               dev_err(&pdev->dev, "unexpected hypervisor error (%d)\n", ret);
+               dev_err(dev, "unexpected hypervisor error (%d)\n", ret);
                return -ENODEV;
        }
 
        if (watchdog_init_timeout(&xen_wdt_dev, timeout, NULL))
                return -ENODEV;
        }
 
        if (watchdog_init_timeout(&xen_wdt_dev, timeout, NULL))
-               dev_info(&pdev->dev, "timeout value invalid, using %d\n",
-                       xen_wdt_dev.timeout);
+               dev_info(dev, "timeout value invalid, using %d\n",
+                        xen_wdt_dev.timeout);
        watchdog_set_nowayout(&xen_wdt_dev, nowayout);
        watchdog_stop_on_reboot(&xen_wdt_dev);
        watchdog_stop_on_unregister(&xen_wdt_dev);
 
        watchdog_set_nowayout(&xen_wdt_dev, nowayout);
        watchdog_stop_on_reboot(&xen_wdt_dev);
        watchdog_stop_on_unregister(&xen_wdt_dev);
 
-       ret = devm_watchdog_register_device(&pdev->dev, &xen_wdt_dev);
+       ret = devm_watchdog_register_device(dev, &xen_wdt_dev);
        if (ret) {
        if (ret) {
-               dev_err(&pdev->dev, "cannot register watchdog device (%d)\n",
-                       ret);
+               dev_err(dev, "cannot register watchdog device (%d)\n", ret);
                return ret;
        }
 
                return ret;
        }
 
-       dev_info(&pdev->dev, "initialized (timeout=%ds, nowayout=%d)\n",
-               xen_wdt_dev.timeout, nowayout);
+       dev_info(dev, "initialized (timeout=%ds, nowayout=%d)\n",
+                xen_wdt_dev.timeout, nowayout);
 
        return 0;
 }
 
        return 0;
 }