riscv: patch: Flush the icache right after patching to avoid illegal insns
authorAlexandre Ghiti <alexghiti@rivosinc.com>
Mon, 24 Jun 2024 08:21:41 +0000 (10:21 +0200)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 26 Jun 2024 14:37:27 +0000 (07:37 -0700)
commitedf2d546bfd6f5c4d143715cef1b1e7ce5718c4e
tree28de2ca8ffa63df562d1a0038633d1f6b9a91bcf
parent04a2aef59cfe192aa99020601d922359978cc72a
riscv: patch: Flush the icache right after patching to avoid illegal insns

We cannot delay the icache flush after patching some functions as we may
have patched a function that will get called before the icache flush.

The only way to completely avoid such scenario is by flushing the icache
as soon as we patch a function. This will probably be costly as we don't
batch the icache maintenance anymore.

Fixes: 6ca445d8af0e ("riscv: Fix early ftrace nop patching")
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-riscv/20240613-lubricant-breath-061192a9489a@wendy/
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Reviewed-by: Andy Chiu <andy.chiu@sifive.com>
Link: https://lore.kernel.org/r/20240624082141.153871-1-alexghiti@rivosinc.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/ftrace.c
arch/riscv/kernel/patch.c