bootconfig: Fix negative seeks on 32-bit with LFS enabled
authorBen Hutchings <benh@debian.org>
Sun, 17 Aug 2025 14:21:46 +0000 (16:21 +0200)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Wed, 20 Aug 2025 23:16:31 +0000 (08:16 +0900)
commit729dc340a4ed1267774fc8518284e976e2210bdc
treec49ed5434ea386fae1005ebc94724ebfc0537db0
parentc17b750b3ad9f45f2b6f7e6f7f4679844244f0b9
bootconfig: Fix negative seeks on 32-bit with LFS enabled

Commit 26dda5769509 "tools/bootconfig: Cleanup bootconfig footer size
calculations" replaced some expressions of type int with the
BOOTCONFIG_FOOTER_SIZE macro, which expands to an expression of type
size_t, which is unsigned.

On 32-bit architectures with LFS enabled (i.e. off_t is 64-bit), the
seek offset of -BOOTCONFIG_FOOTER_SIZE now turns into a positive
value.

Fix this by casting the size to off_t before negating it.

Just in case someone changes BOOTCONFIG_MAGIC_LEN to have type size_t
later, do the same thing to the seek offset of -BOOTCONFIG_MAGIC_LEN.

Link: https://lore.kernel.org/all/aKHlevxeg6Y7UQrz@decadent.org.uk/
Fixes: 26dda5769509 ("tools/bootconfig: Cleanup bootconfig footer size calculations")
Signed-off-by: Ben Hutchings <benh@debian.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
tools/bootconfig/main.c