net: airoha: fix potential use-after-free in airoha_npu_get()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Tue, 15 Jul 2025 14:30:58 +0000 (07:30 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 16 Jul 2025 23:15:09 +0000 (16:15 -0700)
commit3cd582e7d0787506990ef0180405eb6224fa90a6
tree67088af55b8d70f08affed6e95cb7fa0cd58f9ba
parent531d0d32de3e1b6b77a87bd37de0c2c6e17b496a
net: airoha: fix potential use-after-free in airoha_npu_get()

np->name was being used after calling of_node_put(np), which
releases the node and can lead to a use-after-free bug.
Previously, of_node_put(np) was called unconditionally after
of_find_device_by_node(np), which could result in a use-after-free if
pdev is NULL.

This patch moves of_node_put(np) after the error check to ensure
the node is only released after both the error and success cases
are handled appropriately, preventing potential resource issues.

Fixes: 23290c7bc190 ("net: airoha: Introduce Airoha NPU support")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250715143102.3458286-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/airoha/airoha_npu.c