NFC: nci: uart: Set tty->disc_data only in success path
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 18 Jun 2025 07:36:50 +0000 (09:36 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Jun 2025 15:33:54 +0000 (08:33 -0700)
commitfc27ab48904ceb7e4792f0c400f1ef175edf16fe
tree451561d1bdd3594c17049c3bdf68be862a9bb3ba
parent10876da918fa1aec0227fb4c67647513447f53a9
NFC: nci: uart: Set tty->disc_data only in success path

Setting tty->disc_data before opening the NCI device means we need to
clean it up on error paths.  This also opens some short window if device
starts sending data, even before NCIUARTSETDRIVER IOCTL succeeded
(broken hardware?).  Close the window by exposing tty->disc_data only on
the success path, when opening of the NCI device and try_module_get()
succeeds.

The code differs in error path in one aspect: tty->disc_data won't be
ever assigned thus NULL-ified.  This however should not be relevant
difference, because of "tty->disc_data=NULL" in nci_uart_tty_open().

Cc: Linus Torvalds <torvalds@linuxfoundation.org>
Fixes: 9961127d4bce ("NFC: nci: add generic uart support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20250618073649.25049-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/nfc/nci/uart.c