iommu: Prevent pasid attach if no ops->remove_dev_pasid
authorYi Liu <yi.l.liu@intel.com>
Wed, 4 Dec 2024 12:29:22 +0000 (04:29 -0800)
committerJoerg Roedel <jroedel@suse.de>
Wed, 18 Dec 2024 08:39:34 +0000 (09:39 +0100)
commitfb3de9f9b085d003a8a869ca6a4789d1bfbb3f22
treea14eb11497f42794b5750df29154be8fea68eac0
parent78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
iommu: Prevent pasid attach if no ops->remove_dev_pasid

driver should implement both set_dev_pasid and remove_dev_pasid op, otherwise
it is a problem how to detach pasid. In reality, it is impossible that an
iommu driver implements set_dev_pasid() but no remove_dev_pasid() op. However,
it is better to check it.

Move the group check to be the first as dev_iommu_ops() may fail when there
is no valid group. Also take the chance to remove the dev_has_iommu() check
as it is duplicated to the group check.

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20241204122928.11987-2-yi.l.liu@intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/iommu.c