rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
authorMatthias Kaehlcke <mka@chromium.org>
Fri, 9 Feb 2018 00:57:12 +0000 (16:57 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 27 Feb 2018 16:17:30 +0000 (18:17 +0200)
commitfb239c1209bb0f0b4830cc72507cc2f2d63fadbd
treebc0508efd54ff90d8304558849fa51c89720e5e6
parent76d1f95983a0903eaff857ba1e4ec0ac9febf225
rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
is assigned to itself in an if ... else statement, apparently only to
document that the branch condition is handled and that a previously read
value should be returned unmodified. The self-assignment causes clang to
raise the following warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
  error: explicitly assigning value of variable of type 'u32'
    (aka 'unsigned int') to itself [-Werror,-Wself-assign]
  writeVal = writeVal;

Delete the branch with the self-assignment.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c