drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"
authorChristian König <christian.koenig@amd.com>
Wed, 10 Jan 2024 14:19:29 +0000 (15:19 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 18 Jan 2024 21:43:42 +0000 (16:43 -0500)
commitfb1c93c2e9604a884467a773790016199f78ca08
tree8fc4cc03dc3ee8a96896a9d42b1ae20be6a7107a
parent3c4e4eb5d872118fef1708abe933a410c5e07e3a
drm/amdgpu: revert "Adjust removal control flow for smu v13_0_2"

Calling amdgpu_device_ip_resume_phase1() during shutdown leaves the
HW in an active state and is an unbalanced use of the IP callbacks.

Using the IP callbacks like this can lead to memory leaks, double
free and imbalanced reference counters.

Leaving the HW in an active state can lead to DMA accesses to memory now
freed by the driver.

Both is a complete no-go for driver unload so completely revert the
workaround for now.

This reverts commit f5c7e7797060255dbc8160734ccc5ad6183c5e04.

Signed-off-by: Christian König <christian.koenig@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h