dmaengine: idxd: fix calling wq quiesce inside spinlock
authorDave Jiang <dave.jiang@intel.com>
Wed, 17 Nov 2021 17:03:51 +0000 (10:03 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 22 Nov 2021 06:59:50 +0000 (12:29 +0530)
commitfa51b16d05583c7aebbc06330afb50276243d198
tree247e412a5eae041dfe58f412c6ddded7b2d11470
parent1ffc6f359f7ab114ad0d2bbe6a85cbd848709ab2
dmaengine: idxd: fix calling wq quiesce inside spinlock

Dan reports that smatch has found idxd_wq_quiesce() is being called inside
the idxd->dev_lock. idxd_wq_quiesce() calls wait_for_completion() and
therefore it can sleep. Move the call outside of the spinlock as it does
not need device lock.

Fixes: 5b0c68c473a1 ("dmaengine: idxd: support reporting of halt interrupt")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163716858508.1721911.15051495873516709923.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/irq.c