posix-cpu-timers: fix race between handle_posix_cpu_timers() and posix_cpu_timer_del()
authorOleg Nesterov <oleg@redhat.com>
Fri, 13 Jun 2025 17:26:50 +0000 (19:26 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 13 Jun 2025 17:55:49 +0000 (10:55 -0700)
commitf90fff1e152dedf52b932240ebbd670d83330eca
tree82091a26b42acc31e985cad32197d08485fd07a3
parent3ca933aad0aca463512d2f54a79fc65b8ecb0f48
posix-cpu-timers: fix race between handle_posix_cpu_timers() and posix_cpu_timer_del()

If an exiting non-autoreaping task has already passed exit_notify() and
calls handle_posix_cpu_timers() from IRQ, it can be reaped by its parent
or debugger right after unlock_task_sighand().

If a concurrent posix_cpu_timer_del() runs at that moment, it won't be
able to detect timer->it.cpu.firing != 0: cpu_timer_task_rcu() and/or
lock_task_sighand() will fail.

Add the tsk->exit_state check into run_posix_cpu_timers() to fix this.

This fix is not needed if CONFIG_POSIX_CPU_TIMERS_TASK_WORK=y, because
exit_task_work() is called before exit_notify(). But the check still
makes sense, task_work_add(&tsk->posix_cputimers_work.work) will fail
anyway in this case.

Cc: stable@vger.kernel.org
Reported-by: BenoƮt Sevens <bsevens@google.com>
Fixes: 0bdd2ed4138e ("sched: run_posix_cpu_timers: Don't check ->exit_state, use lock_task_sighand()")
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/time/posix-cpu-timers.c