net: bnx2x: fix variable dereferenced before check
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 13 Nov 2021 22:36:36 +0000 (01:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Nov 2021 13:28:49 +0000 (13:28 +0000)
commitf8885ac89ce310570e5391fe0bf0ec9c7c9b4fdc
tree30c03089c68719bf586e2cfa5b3f1ee0460f741c
parent2153bd1e3d3dbf6a3403572084ef6ed31c53c5f0
net: bnx2x: fix variable dereferenced before check

Smatch says:
bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op()
warn: variable dereferenced before check 'ilt' (see line 638)

Move ilt_cli variable initialization _after_ ilt validation, because
it's unsafe to deref the pointer before validation check.

Fixes: 523224a3b3cd ("bnx2x, cnic, bnx2i: use new FW/HSI")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_init_ops.h