scsi: lpfc: Fix negation of else clause in lpfc_prep_node_fc4type
authorDick Kennedy <dick.kennedy@broadcom.com>
Fri, 1 May 2020 21:43:05 +0000 (14:43 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 8 May 2020 02:47:22 +0000 (22:47 -0400)
commitf809da6db68a8be49e317f0ccfbced1af9258839
tree0d2dc34e142e5bd2f3e48e7217f41d4bc95711cc
parentb98214f6070ef5052b763b61ac2089a9ac6c8677
scsi: lpfc: Fix negation of else clause in lpfc_prep_node_fc4type

Implementation of a previous patch added a condition to an if check that
always end up with the if test being true. Execution of the else clause was
inadvertently negated.  The additional condition check was incorrect and
unnecessary after the other modifications had been done in that patch.

Remove the check from the if series.

Link: https://lore.kernel.org/r/20200501214310.91713-5-jsmart2021@gmail.com
Fixes: b95b21193c85 ("scsi: lpfc: Fix loss of remote port after devloss due to lack of RPIs")
Cc: <stable@vger.kernel.org> # v5.4+
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_ct.c