sched: cls_bpf: fix panic on filter replace
authorDaniel Borkmann <daniel@iogearbox.net>
Fri, 17 Jul 2015 20:38:43 +0000 (22:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jul 2015 07:25:02 +0000 (00:25 -0700)
commitf6bfc46da6292b630ba389592123f0dd02066172
treee43402df77d5320662706769e70b5e783fadeb1d
parent27dfead164451971f2c3778857b43690e7afaa8b
sched: cls_bpf: fix panic on filter replace

The following test case causes a NULL pointer dereference in cls_bpf:

  FOO="1,6 0 0 4294967295,"
  tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok
  tc filter replace dev foo parent 1: pref 49152 handle 0x1 \
            bpf bytecode "$FOO" flowid 1:1 action drop

The problem is that commit 1f947bf151e9 ("net: sched: rcu'ify cls_bpf")
accidentally swapped the arguments of list_replace_rcu(), the old
element needs to be the first argument and the new element the second.

Fixes: 1f947bf151e9 ("net: sched: rcu'ify cls_bpf")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_bpf.c