drm/mediatek: Initialize pointer in mtk_drm_of_ddp_path_build_one()
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tue, 12 Nov 2024 10:50:30 +0000 (11:50 +0100)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Sat, 4 Jan 2025 12:15:19 +0000 (12:15 +0000)
commitf563dd9ca6cb6ed52c5fb6e4285d1ef26cfa7e8a
tree03cf2c4149a92c0c901aa7f5286e484db1d8d52e
parent522908140645865dc3e2fac70fd3b28834dfa7be
drm/mediatek: Initialize pointer in mtk_drm_of_ddp_path_build_one()

The struct device_node *next pointer is not initialized, and it is
used in an error path in which it may have never been modified by
function mtk_drm_of_get_ddp_ep_cid().

Since the error path is relying on that pointer being NULL for the
OVL Adaptor and/or invalid component check and since said pointer
is being used in prints for %pOF, in the case that it points to a
bogus address, the print may cause a KP.

To resolve that, initialize the *next pointer to NULL before usage.

Fixes: 4c932840db1d ("drm/mediatek: Implement OF graphs support for display paths")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/dri-devel/633f3c6d-d09f-447c-95f1-dfb4114c50e6@stanley.mountain/
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20241112105030.93337-1-angelogioacchino.delregno@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_drv.c