netfilter: conntrack: clean up returns in nf_conntrack_log_invalid_sysctl()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 4 Aug 2025 10:35:15 +0000 (13:35 +0300)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 7 Aug 2025 11:19:26 +0000 (13:19 +0200)
commitf54186df806fb1e9cb262d553f4ff942f9467cf1
treef068af104f5132cd506ac47e6849367d30bf8c01
parentc8a7c2c608180f3b4e51dc958b3861242dcdd76d
netfilter: conntrack: clean up returns in nf_conntrack_log_invalid_sysctl()

Smatch complains that these look like error paths with missing error
codes, especially the one where we return if nf_log_is_registered() is
true:

    net/netfilter/nf_conntrack_standalone.c:575 nf_conntrack_log_invalid_sysctl()
    warn: missing error code? 'ret'

In fact, all these return zero deliberately.  Change them to return a
literal instead which helps readability as well as silencing the warning.

Fixes: e89a68046687 ("netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Lance Yang <lance.yang@linux.dev>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_standalone.c