idpf: improve when to set RE bit logic
authorJoshua Hay <joshua.a.hay@intel.com>
Fri, 25 Jul 2025 18:42:19 +0000 (11:42 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 21 Aug 2025 16:04:58 +0000 (09:04 -0700)
commitf2d18e16479cac7a708d77cbfb4220a9114a71fc
treefb770ed552dedee9e49bec4d605a709f7adb2ee7
parentcb83b559bea39f207ee214ee2972657e8576ed18
idpf: improve when to set RE bit logic

Track the gap between next_to_use and the last RE index. Set RE again
if the gap is large enough to ensure RE bit is set frequently. This is
critical before removing the stashing mechanisms because the
opportunistic descriptor ring cleaning from the out-of-order completions
will go away. Previously the descriptors would be "cleaned" by both the
descriptor (RE) completion and the out-of-order completions. Without the
latter, we must ensure the RE bit is set more frequently. Otherwise,
it's theoretically possible for the descriptor ring next_to_clean to
never advance.  The previous implementation was dependent on the start
of a packet falling on a 64th index in the descriptor ring, which is not
guaranteed with large packets.

Signed-off-by: Luigi Rizzo <lrizzo@google.com>
Signed-off-by: Brian Vazquez <brianvv@google.com>
Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Tested-by: Samuel Salin <Samuel.salin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_txrx.c
drivers/net/ethernet/intel/idpf/idpf_txrx.h