scsi: smartpqi: revert propagate-the-multipath-failure-to-SML-quickly
authorGilbert Wu <Gilbert.Wu@microchip.com>
Thu, 11 Jul 2024 19:47:02 +0000 (14:47 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 3 Aug 2024 02:07:18 +0000 (22:07 -0400)
commitf1393d52e6cda9c20f12643cbecf1e1dc357e0e2
treeefa4fd9382f7240a65467e9ecadfb165554a1391
parentbb0f5445b27f4a8f8359cc0f36a59a397b4b5e0c
scsi: smartpqi: revert propagate-the-multipath-failure-to-SML-quickly

Correct a rare multipath failure issue by reverting commit 94a68c814328
("scsi: smartpqi: Quickly propagate path failures to SCSI midlayer") [1].

Reason for revert: The patch propagated the path failure to SML quickly
when one of the path fails during IO and AIO path gets disabled for a
multipath device.

But it created a new issue: when creating a volume on an encryption-enabled
controller, the firmware reports the AIO path is disabled, which cause the
driver to report a path failure to SML for a multipath device.

There will be a new fix to handle "Illegal request" and "Invalid field in
parameter list" on RAID path when the AIO path is disabled on a multipath
device.

[1] https://lore.kernel.org/all/164375209313.440833.9992416628621839233.stgit@brunhilda.pdev.net/

Fixes: 94a68c814328 ("scsi: smartpqi: Quickly propagate path failures to SCSI midlayer")
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: Gilbert Wu <Gilbert.Wu@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
Link: https://lore.kernel.org/r/20240711194704.982400-4-don.brace@microchip.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/smartpqi/smartpqi_init.c