uio: potential double frees if __uio_register_device() fails
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 2 Aug 2018 08:24:47 +0000 (11:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Aug 2018 08:42:25 +0000 (10:42 +0200)
commitf019f07ecf6a6b8bd6d7853bce70925d90af02d1
tree306aaab3bd5fbb0dd5939761af519eeba6e6a505
parentc01513b4b29953e6ba8a8d8de77fb5ca2f01c48f
uio: potential double frees if __uio_register_device() fails

The uio_unregister_device() function assumes that if "info->uio_dev" is
non-NULL that means "info" is fully allocated.  Setting info->uio_de
has to be the last thing in the function.

In the current code, if request_threaded_irq() fails then we return with
info->uio_dev set to non-NULL but info is not fully allocated and it can
lead to double frees.

Fixes: beafc54c4e2f ("UIO: Add the User IO core code")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio.c