drm/rockchip: cdn-dp: fix sign extension on an int multiply for a u64 result
authorColin Ian King <colin.king@canonical.com>
Tue, 15 Sep 2020 16:20:49 +0000 (17:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:56:17 +0000 (16:56 +0200)
commiteee0f7d399b683d856ff5b1b2627306ec32f703e
tree2e12d0ab8604a5298e223710c6dc4820d4eca6a8
parent75db503c9cc7344eac8aba8d54e31db8656b1293
drm/rockchip: cdn-dp: fix sign extension on an int multiply for a u64 result

[ Upstream commit ce0cb93a5adb283f577cd4661f511047b5e39028 ]

The variable bit_per_pix is a u8 and is promoted in the multiplication
to an int type and then sign extended to a u64. If the result of the
int multiplication is greater than 0x7fffffff then the upper 32 bits will
be set to 1 as a result of the sign extension. Avoid this by casting
tu_size_reg to u64 to avoid sign extension and also a potential overflow.

Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200915162049.36434-1-colin.king@canonical.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/rockchip/cdn-dp-reg.c