media: av7110: prevent underflow in write_ts_to_decoder()
authorDan Carpenter <error27@gmail.com>
Tue, 7 Mar 2023 10:00:23 +0000 (11:00 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 19 Mar 2023 21:57:50 +0000 (22:57 +0100)
commiteed9496a0501357aa326ddd6b71408189ed872eb
treed4124ee8573dd2f1e32cfd0c24309e6109a98383
parent4ae47770d57bff0193fbbf48d56c18759cad5f6e
media: av7110: prevent underflow in write_ts_to_decoder()

The buf[4] value comes from the user via ts_play().  It is a value in
the u8 range.  The final length we pass to av7110_ipack_instant_repack()
is "len - (buf[4] + 1) - 4" so add a check to ensure that the length is
not negative.  It's not clear that passing a negative len value does
anything bad necessarily, but it's not best practice.

With the new bounds checking the "if (!len)" condition is no longer
possible or required so remove that.

Fixes: fd46d16d602a ("V4L/DVB (11759): dvb-ttpci: Add TS replay capability")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/av7110/av7110_av.c