drm/i915: use mock device info for creating mock device
authorJani Nikula <jani.nikula@intel.com>
Tue, 27 Jun 2023 15:13:58 +0000 (18:13 +0300)
committerJani Nikula <jani.nikula@intel.com>
Thu, 29 Jun 2023 13:27:58 +0000 (16:27 +0300)
commitecc7a3ce078a209a62af4c53ffb7370620f65c24
treed7adbd1f8538eab95480eb476591dfbdbc73d76c
parent9124f2b7ff7fdd185cd33612b459bafa6c605b46
drm/i915: use mock device info for creating mock device

Instead of modifying the device info on the fly, use static const mock
device info.

It's not okay to modify device info at runtime; we've added separate
runtime info for info that needs to be modified at runtime. We've added
safeguards to device info to prevent it from being modified, but commit
5e352e32aec2 ("drm/i915: preparation for using PAT index") just cast the
const away and modified it anyway. This prevents device info from being
moved to rodata.

Fixes: 5e352e32aec2 ("drm/i915: preparation for using PAT index")
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Fei Yang <fei.yang@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/b0db62045a96a3fd4cf123685da88cc777f9b485.1687878757.git.jani.nikula@intel.com
drivers/gpu/drm/i915/selftests/mock_gem_device.c