ovl: don't allow datadir only
authorMiklos Szeredi <mszeredi@redhat.com>
Mon, 10 Feb 2025 14:11:22 +0000 (15:11 +0100)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 7 Apr 2025 09:22:49 +0000 (11:22 +0200)
commiteb3a04a8516ee9b5174379306f94279fc90424c4
treecfe186d5f93617176c68222410eb7dfa172c32ac
parent0af2f6be1b4281385b618cb86ad946eded089ac8
ovl: don't allow datadir only

In theory overlayfs could support upper layer directly referring to a data
layer, but there's no current use case for this.

Originally, when data-only layers were introduced, this wasn't allowed,
only introduced by the "datadir+" feature, but without actually handling
this case, resulting in an Oops.

Fix by disallowing datadir without lowerdir.

Reported-by: Giuseppe Scrivano <gscrivan@redhat.com>
Fixes: 24e16e385f22 ("ovl: add support for appending lowerdirs one by one")
Cc: <stable@vger.kernel.org> # v6.7
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Alexander Larsson <alexl@redhat.com>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/super.c