perf script: perf script tests fails with segfault
authorAditya Bodkhe <aditya.b1@linux.ibm.com>
Tue, 29 Apr 2025 06:51:32 +0000 (12:21 +0530)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 10 Jun 2025 04:38:08 +0000 (21:38 -0700)
commitea04fe1b90cbb42966b471a4982bc52215b62857
treec97a5b1a5fa0497d751d3c119e77cbf371ab55db
parent63e37590cd73b0aaf0dbee3c8bdb00c3ff77c8da
perf script: perf script tests fails with segfault

pert script tests fails with segmentation fault as below:

  92: perf script tests:
  --- start ---
  test child forked, pid 103769
  DB test
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.012 MB /tmp/perf-test-script.7rbftEpOzX/perf.data (9 samples) ]
  /usr/libexec/perf-core/tests/shell/script.sh: line 35:
  103780 Segmentation fault      (core dumped)
  perf script -i "${perfdatafile}" -s "${db_test}"
  --- Cleaning up ---
  ---- end(-1) ----
  92: perf script tests                                               : FAILED!

Backtrace pointed to :
#0  0x0000000010247dd0 in maps.machine ()
#1  0x00000000101d178c in db_export.sample ()
#2  0x00000000103412c8 in python_process_event ()
#3  0x000000001004eb28 in process_sample_event ()
#4  0x000000001024fcd0 in machines.deliver_event ()
#5  0x000000001025005c in perf_session.deliver_event ()
#6  0x00000000102568b0 in __ordered_events__flush.part.0 ()
#7  0x0000000010251618 in perf_session.process_events ()
#8  0x0000000010053620 in cmd_script ()
#9  0x00000000100b5a28 in run_builtin ()
#10 0x00000000100b5f94 in handle_internal_command ()
#11 0x0000000010011114 in main ()

Further investigation reveals that this occurs in the `perf script tests`,
because it uses `db_test.py` script. This script sets `perf_db_export_mode = True`.

With `perf_db_export_mode` enabled, if a sample originates from a hypervisor,
perf doesn't set maps for "[H]" sample in the code. Consequently, `al->maps` remains NULL
when `maps__machine(al->maps)` is called from `db_export__sample`.

As al->maps can be NULL in case of Hypervisor samples , use thread->maps
because even for Hypervisor sample, machine should exist.
If we don't have machine for some reason, return -1 to avoid segmentation fault.

Reported-by: Disha Goel <disgoel@linux.ibm.com>
Signed-off-by: Aditya Bodkhe <aditya.b1@linux.ibm.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Disha Goel <disgoel@linux.ibm.com>
Link: https://lore.kernel.org/r/20250429065132.36839-1-adityab1@linux.ibm.com
Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/db-export.c
tools/perf/util/scripting-engines/trace-event-python.c