net: sfp: Always call `sfp_sm_mod_remove()` on remove
authorCsókás, Bence <csokas.bence@prolan.hu>
Wed, 5 Jun 2024 08:42:51 +0000 (10:42 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Jun 2024 00:34:03 +0000 (17:34 -0700)
commite96b2933152fd87b6a41765b2f58b158fde855b6
tree4c592cdcd4c0c9752820a813201a2957a620497a
parentd30d0e49da71de8df10bf3ff1b3de880653af562
net: sfp: Always call `sfp_sm_mod_remove()` on remove

If the module is in SFP_MOD_ERROR, `sfp_sm_mod_remove()` will
not be run. As a consequence, `sfp_hwmon_remove()` is not getting
run either, leaving a stale `hwmon` device behind. `sfp_sm_mod_remove()`
itself checks `sfp->sm_mod_state` anyways, so this check was not
really needed in the first place.

Fixes: d2e816c0293f ("net: sfp: handle module remove outside state machine")
Signed-off-by: "Csókás, Bence" <csokas.bence@prolan.hu>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240605084251.63502-1-csokas.bence@prolan.hu
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/sfp.c