dm verity: fix error handling for check_at_most_once on FEC
authorYeongjin Gil <youngjin.gil@samsung.com>
Mon, 20 Mar 2023 06:59:32 +0000 (15:59 +0900)
committerMike Snitzer <snitzer@kernel.org>
Tue, 4 Apr 2023 15:03:39 +0000 (11:03 -0400)
commite8c5d45f82ce0c238a4817739892fe8897a3dcc3
treedf50be117fe91449a14a409f05a82d8c6279c70e
parent363b7fd76c91dc611a56d992e9550bb1ba070e1a
dm verity: fix error handling for check_at_most_once on FEC

In verity_end_io(), if bi_status is not BLK_STS_OK, it can be return
directly. But if FEC configured, it is desired to correct the data page
through verity_verify_io. And the return value will be converted to
blk_status and passed to verity_finish_io().

BTW, when a bit is set in v->validated_blocks, verity_verify_io() skips
verification regardless of I/O error for the corresponding bio. In this
case, the I/O error could not be returned properly, and as a result,
there is a problem that abnormal data could be read for the
corresponding block.

To fix this problem, when an I/O error occurs, do not skip verification
even if the bit related is set in v->validated_blocks.

Fixes: 843f38d382b1 ("dm verity: add 'check_at_most_once' option to only validate hashes once")
Cc: stable@vger.kernel.org
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Yeongjin Gil <youngjin.gil@samsung.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-verity-target.c