net: Update threaded state in napi config in netif_set_threaded
authorSamiullah Khawaja <skhawaja@google.com>
Mon, 4 Aug 2025 16:44:57 +0000 (16:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Aug 2025 00:46:15 +0000 (17:46 -0700)
commite6d76268813dc64cc0b74ea9c274501f2de05344
tree218e1cfbecb545f3102d922197aa1028c6ba96a0
parent8d22aea8af0d57a1daff046d65b7c18552e35e29
net: Update threaded state in napi config in netif_set_threaded

Commit 2677010e7793 ("Add support to set NAPI threaded for individual
NAPI") added support to enable/disable threaded napi using netlink. This
also extended the napi config save/restore functionality to set the napi
threaded state. This breaks netdev reset for drivers that use napi
threaded at device level and also use napi config save/restore on
napi_disable/napi_enable. Basically on netdev with napi threaded enabled
at device level, a napi_enable call will get stuck trying to stop the
napi kthread. This is because the napi->config->threaded is set to
disabled when threaded is enabled at device level.

The issue can be reproduced on virtio-net device using qemu. To
reproduce the issue run following,

  echo 1 > /sys/class/net/threaded
  ethtool -L eth0 combined 1

Update the threaded state in napi config in netif_set_threaded and add a
new test that verifies this scenario.

Tested on qemu with virtio-net:
 NETIF=eth0 ./tools/testing/selftests/drivers/net/napi_threaded.py
 TAP version 13
 1..2
 ok 1 napi_threaded.change_num_queues
 ok 2 napi_threaded.enable_dev_threaded_disable_napi_threaded
 # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0

Fixes: 2677010e7793 ("Add support to set NAPI threaded for individual NAPI")
Signed-off-by: Samiullah Khawaja <skhawaja@google.com>
Link: https://patch.msgid.link/20250804164457.2494390-1-skhawaja@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c
tools/testing/selftests/drivers/net/Makefile
tools/testing/selftests/drivers/net/napi_threaded.py [new file with mode: 0755]