net: ping6: Fix ping -6 with interface name
authorAya Levin <ayal@nvidia.com>
Tue, 31 May 2022 08:45:44 +0000 (11:45 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 1 Jun 2022 10:44:42 +0000 (12:44 +0200)
commite6652a8ef3e64d953168a95878fe29b934ad78ac
tree30b71def0ccadbccd9565be35fabf6f088774182
parent196a888ca6571deb344468e1d7138e3273206335
net: ping6: Fix ping -6 with interface name

When passing interface parameter to ping -6:
$ ping -6 ::11:141:84:9 -I eth2
Results in:
PING ::11:141:84:10(::11:141:84:10) from ::11:141:84:9 eth2: 56 data bytes
ping: sendmsg: Invalid argument
ping: sendmsg: Invalid argument

Initialize the fl6's outgoing interface (OIF) before triggering
ip6_datagram_send_ctl. Don't wipe fl6 after ip6_datagram_send_ctl() as
changes in fl6 that may happen in the function are overwritten explicitly.
Update comment accordingly.

Fixes: 13651224c00b ("net: ping6: support setting basic SOL_IPV6 options via cmsg")
Signed-off-by: Aya Levin <ayal@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20220531084544.15126-1-tariqt@nvidia.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/ping.c