scsi: mpi3mr: Fix race between config read submit and interrupt completion
authorRanjan Kumar <ranjan.kumar@broadcom.com>
Fri, 27 Jun 2025 19:45:36 +0000 (01:15 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 15 Jul 2025 00:52:45 +0000 (20:52 -0400)
commite6327c4acf925bb6d6d387d76fc3bd94471e10d8
treeab0d879b15ef5e5efa88f2222916790e5f2ac127
parent19272b37aa4f83ca52bdf9c16d5d81bdd1354494
scsi: mpi3mr: Fix race between config read submit and interrupt completion

The "is_waiting" flag was updated after calling complete(), which could
lead to a race where the waiting thread wakes up before the flag is
cleared. This may cause a missed wakeup or stale state check.

Reorder the operations to update "is_waiting" before signaling completion
to ensure consistent state.

Fixes: 824a156633df ("scsi: mpi3mr: Base driver code")
Cc: stable@vger.kernel.org
Co-developed-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
Link: https://lore.kernel.org/r/20250627194539.48851-2-ranjan.kumar@broadcom.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr_fw.c