amba: Make the remove callback return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 26 Jan 2021 16:58:34 +0000 (17:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:40:02 +0000 (14:40 +0200)
commite4c777fd8c371b2a46b7541fbd92903d700def11
tree853568f38585b15e15e581fd5d3c96460cfcaded
parent1c6ac39763bc2bbee789ad9f7f527066a50abb9a
amba: Make the remove callback return void

[ Upstream commit 3fd269e74f2feec973f45ee11d822faeda4fe284 ]

All amba drivers return 0 in their remove callback. Together with the
driver core ignoring the return value anyhow, it doesn't make sense to
return a value here.

Change the remove prototype to return void, which makes it explicit that
returning an error value doesn't work as expected. This simplifies changing
the core remove callback to return void, too.

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> # for hwtracing/coresight
Acked-By: Vinod Koul <vkoul@kernel.org> # for dmaengine
Acked-by: Guenter Roeck <linux@roeck-us.net> # for watchdog
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
Acked-by: Takashi Iwai <tiwai@suse.de> # for sound
Acked-by: Vladimir Zapolskiy <vz@mleia.com> # for memory/pl172
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210126165835.687514-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
30 files changed:
drivers/amba/bus.c
drivers/char/hw_random/nomadik-rng.c
drivers/dma/pl330.c
drivers/gpu/drm/pl111/pl111_drv.c
drivers/hwtracing/coresight/coresight-catu.c
drivers/hwtracing/coresight/coresight-cpu-debug.c
drivers/hwtracing/coresight/coresight-cti-core.c
drivers/hwtracing/coresight/coresight-etb10.c
drivers/hwtracing/coresight/coresight-etm3x-core.c
drivers/hwtracing/coresight/coresight-etm4x-core.c
drivers/hwtracing/coresight/coresight-funnel.c
drivers/hwtracing/coresight/coresight-replicator.c
drivers/hwtracing/coresight/coresight-stm.c
drivers/hwtracing/coresight/coresight-tmc-core.c
drivers/hwtracing/coresight/coresight-tpiu.c
drivers/i2c/busses/i2c-nomadik.c
drivers/input/serio/ambakmi.c
drivers/memory/pl172.c
drivers/memory/pl353-smc.c
drivers/mmc/host/mmci.c
drivers/rtc/rtc-pl030.c
drivers/rtc/rtc-pl031.c
drivers/spi/spi-pl022.c
drivers/tty/serial/amba-pl010.c
drivers/tty/serial/amba-pl011.c
drivers/vfio/platform/vfio_amba.c
drivers/video/fbdev/amba-clcd.c
drivers/watchdog/sp805_wdt.c
include/linux/amba/bus.h
sound/arm/aaci.c