btrfs: qgroup: set quota enabled bit if quota disable fails flushing reservations
authorFilipe Manana <fdmanana@suse.com>
Tue, 1 Jul 2025 10:39:44 +0000 (11:39 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Jul 2025 22:07:08 +0000 (00:07 +0200)
commite41c75ca3189341e76e6af64b857c05b68a1d7db
tree6f80a3bacb7258562e31874473a1eb890f198c06
parent736bd9d2e35866a07f32d9884019e0431b0b50d8
btrfs: qgroup: set quota enabled bit if quota disable fails flushing reservations

Before waiting for the rescan worker to finish and flushing reservations,
we clear the BTRFS_FS_QUOTA_ENABLED flag from fs_info. If we fail flushing
reservations we leave with the flag not set which is not correct since
quotas are still enabled - we must set back the flag on error paths, such
as when we fail to start a transaction, except for error paths that abort
a transaction. The reservation flushing happens very early before we do
any operation that actually disables quotas and before we start a
transaction, so set back BTRFS_FS_QUOTA_ENABLED if it fails.

Fixes: af0e2aab3b70 ("btrfs: qgroup: flush reservations during quota disable")
CC: stable@vger.kernel.org # 6.12+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c