mfd: cros_ec: Separate charge-control probing from USB-PD
authorThomas Weißschuh <linux@weissschuh.net>
Wed, 21 May 2025 14:42:51 +0000 (16:42 +0200)
committerLee Jones <lee@kernel.org>
Thu, 24 Jul 2025 10:26:54 +0000 (11:26 +0100)
commite40fc1160d491c3bcaf8e940ae0dde0a7c5e8e14
tree49653a05bd72e7dff710287a5ef5d7648f1cfd9f
parent6f27d26e363a41fc651be852094823ce47a43243
mfd: cros_ec: Separate charge-control probing from USB-PD

The charge-control subsystem in the ChromeOS EC is not strictly tied to
its USB-PD subsystem.

Since commit 7613bc0d116a ("mfd: cros_ec: Don't load charger with UCSI")
the presence of EC_FEATURE_UCSI_PPM would inhibit the probing of the
charge-control driver.

Furthermore recent versions of the EC firmware in Framework laptops
hard-disable EC_FEATURE_USB_PD to avoid probing cros-usbpd-charger,
which then also breaks cros-charge-control.

Instead use the dedicated EC_FEATURE_CHARGER.

Cc: stable@vger.kernel.org
Link: https://github.com/FrameworkComputer/EmbeddedController/commit/1d7bcf1d50137c8c01969eb65880bc83e424597e
Fixes: 555b5fcdb844 ("mfd: cros_ec: Register charge control subdevice")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Tested-by: Tom Vincent <linux@tlvince.com>
Link: https://lore.kernel.org/r/20250521-cros-ec-mfd-chctl-probe-v1-1-6ebfe3a6efa7@weissschuh.net
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/cros_ec_dev.c