projects / linux-2.6-block.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7cb4357) | patch
ipv4: Check !in_dev earlier for ioctl(SIOCSIFADDR).
authorKuniyuki Iwashima <kuniyu@amazon.com>
Fri, 9 Aug 2024 23:54:02 +0000 (16:54 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 16 Aug 2024 01:56:13 +0000 (18:56 -0700)
commite3af3d3c5b26c33a7950e34e137584f6056c4319
tree20a539d2a97e0d82622f4d54b8b59476ee91d834tree | snapshot
parent7cb43579641dc437941782b473387c6f8bbc1d25commit | diff
ipv4: Check !in_dev earlier for ioctl(SIOCSIFADDR).

dev->ip_ptr could be NULL if we set an invalid MTU.

Even then, if we issue ioctl(SIOCSIFADDR) for a new IPv4 address,
devinet_ioctl() allocates struct in_ifaddr and fails later in
inet_set_ifa() because in_dev is NULL.

Let's move the check earlier.

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20240809235406.50187-2-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/devinet.c diff | blob | blame | history
Linux 6.x block layer and io_uring tree(s)