ksmbd: fix type confusion via race condition when using ipc_msg_send_request
authorNamjae Jeon <linkinjeon@kernel.org>
Fri, 21 Feb 2025 05:16:23 +0000 (14:16 +0900)
committerSteve French <stfrench@microsoft.com>
Mon, 3 Mar 2025 04:50:53 +0000 (22:50 -0600)
commite2ff19f0b7a30e03516e6eb73b948e27a55bc9d2
treeabc6234b9ad0a8c3f04d06b8dd5162817cacc16d
parentd6e13e19063db24f94b690159d0633aaf72a0f03
ksmbd: fix type confusion via race condition when using ipc_msg_send_request

req->handle is allocated using ksmbd_acquire_id(&ipc_ida), based on
ida_alloc. req->handle from ksmbd_ipc_login_request and
FSCTL_PIPE_TRANSCEIVE ioctl can be same and it could lead to type confusion
between messages, resulting in access to unexpected parts of memory after
an incorrect delivery. ksmbd check type of ipc response but missing add
continue to check next ipc reponse.

Cc: stable@vger.kernel.org
Reported-by: Norbert Szetei <norbert@doyensec.com>
Tested-by: Norbert Szetei <norbert@doyensec.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/transport_ipc.c