nvme-tcp: fix possible use-after-free in transport error_recovery work
authorSagi Grimberg <sagi@grimberg.me>
Tue, 1 Feb 2022 12:54:20 +0000 (14:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Feb 2022 11:01:00 +0000 (12:01 +0100)
commite192184cf8bce8dd55d619f5611a2eaba996fa05
treec665a3281f9fb71969c8155c2d6d8ee9bdf02821
parent0ead57ceb21bbf15963b4874c2ac67143455382f
nvme-tcp: fix possible use-after-free in transport error_recovery work

[ Upstream commit ff9fc7ebf5c06de1ef72a69f9b1ab40af8b07f9e ]

While nvme_tcp_submit_async_event_work is checking the ctrl and queue
state before preparing the AER command and scheduling io_work, in order
to fully prevent a race where this check is not reliable the error
recovery work must flush async_event_work before continuing to destroy
the admin queue after setting the ctrl state to RESETTING such that
there is no race .submit_async_event and the error recovery handler
itself changing the ctrl state.

Tested-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/tcp.c