sched/ext: Prevent update_locked_rq() calls with NULL rq
authorBreno Leitao <leitao@debian.org>
Wed, 16 Jul 2025 17:38:48 +0000 (10:38 -0700)
committerTejun Heo <tj@kernel.org>
Thu, 17 Jul 2025 01:02:12 +0000 (15:02 -1000)
commite14fd98c6d66cb76694b12c05768e4f9e8c95664
treef9921177f9568e83adb6f96c17db56ede564b59d
parent7980ad7e4ca80f6c255f4473fba82a475342035a
sched/ext: Prevent update_locked_rq() calls with NULL rq

Avoid invoking update_locked_rq() when the runqueue (rq) pointer is NULL
in the SCX_CALL_OP and SCX_CALL_OP_RET macros.

Previously, calling update_locked_rq(NULL) with preemption enabled could
trigger the following warning:

    BUG: using __this_cpu_write() in preemptible [00000000]

This happens because __this_cpu_write() is unsafe to use in preemptible
context.

rq is NULL when an ops invoked from an unlocked context. In such cases, we
don't need to store any rq, since the value should already be NULL
(unlocked). Ensure that update_locked_rq() is only called when rq is
non-NULL, preventing calling __this_cpu_write() on preemptible context.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Fixes: 18853ba782bef ("sched_ext: Track currently locked rq")
Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # v6.15
kernel/sched/ext.c