xfrm: Fix xfrm migrate issues when address family changes
authorYan Yan <evitayan@google.com>
Wed, 19 Jan 2022 00:00:14 +0000 (16:00 -0800)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 26 Jan 2022 06:44:02 +0000 (07:44 +0100)
commite03c3bba351f99ad932e8f06baa9da1afc418e02
treef9ae03d6c57d413d828e7f3b04a08b3f35818808
parentc1aca3080e382886e2e58e809787441984a2f89b
xfrm: Fix xfrm migrate issues when address family changes

xfrm_migrate cannot handle address family change of an xfrm_state.
The symptons are the xfrm_state will be migrated to a wrong address,
and sending as well as receiving packets wil be broken.

This commit fixes it by breaking the original xfrm_state_clone
method into two steps so as to update the props.family before
running xfrm_init_state. As the result, xfrm_state's inner mode,
outer mode, type and IP header length in xfrm_state_migrate can
be updated with the new address family.

Tested with additions to Android's kernel unit test suite:
https://android-review.googlesource.com/c/kernel/tests/+/1885354

Signed-off-by: Yan Yan <evitayan@google.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_state.c