ntb_hw_switchtec: Fix shift-out-of-bounds in switchtec_ntb_mw_set_trans
authorYajun Deng <yajun.deng@linux.dev>
Wed, 16 Aug 2023 08:33:05 +0000 (16:33 +0800)
committerJon Mason <jdmason@kudzu.us>
Tue, 18 Mar 2025 14:22:47 +0000 (10:22 -0400)
commitde203da734fae00e75be50220ba5391e7beecdf9
tree351d6fa20964a47db067aedbc1001c84fea92229
parent2014c95afecee3e76ca4a56956a936e23283f05b
ntb_hw_switchtec: Fix shift-out-of-bounds in switchtec_ntb_mw_set_trans

There is a kernel API ntb_mw_clear_trans() would pass 0 to both addr and
size. This would make xlate_pos negative.

[   23.734156] switchtec switchtec0: MW 0: part 0 addr 0x0000000000000000 size 0x0000000000000000
[   23.734158] ================================================================================
[   23.734172] UBSAN: shift-out-of-bounds in drivers/ntb/hw/mscc/ntb_hw_switchtec.c:293:7
[   23.734418] shift exponent -1 is negative

Ensuring xlate_pos is a positive or zero before BIT.

Fixes: 1e2fd202f859 ("ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()")
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/hw/mscc/ntb_hw_switchtec.c