fs/resctrl: Restore the rdt_last_cmd_clear() calls after acquiring rdtgroup_mutex
authorZeng Heng <zengheng4@huawei.com>
Tue, 3 Jun 2025 12:58:28 +0000 (20:58 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 4 Jun 2025 18:32:55 +0000 (20:32 +0200)
commitdd2922dcfaa3296846265e113309e5f7f138839f
tree32dd9bee1ad91881ddcb9a0d2572c9f88596d106
parent8b68e978718f14fdcb080c2a7791c52a0d09bc6d
fs/resctrl: Restore the rdt_last_cmd_clear() calls after acquiring rdtgroup_mutex

A lockdep fix removed two rdt_last_cmd_clear() calls that were used to
clear the last_cmd_status buffer but called without holding the required
rdtgroup_mutex.

The impacted resctrl commands are writing to the cpus or cpus_list files
and creating a new monitor or control group. With stale data in the
last_cmd_status buffer the impacted resctrl commands report the stale error
on success, or append its own failure message to the stale error on
failure.

Consequently, restore the rdt_last_cmd_clear() calls after acquiring
rdtgroup_mutex.

Fixes: c8eafe149530 ("x86/resctrl: Fix potential lockdep warning")
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/all/20250603125828.1590067-1-zengheng4@huawei.com
fs/resctrl/rdtgroup.c