document while_each_thread(), change first_tid() to use for_each_thread()
authorOleg Nesterov <oleg@redhat.com>
Wed, 23 Aug 2023 17:08:06 +0000 (19:08 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 24 Aug 2023 23:25:15 +0000 (16:25 -0700)
commitdce8f8ed1de1d9d6d27c5ccd202ce4ec163b100c
tree93e6156402383138221d53cb0937d28cefa97cf0
parented1af26cd24811c3ddb5e7a276e3c6362c989bba
document while_each_thread(), change first_tid() to use for_each_thread()

Add the comment to explain that while_each_thread(g,t) is not rcu-safe
unless g is stable (e.g.  current).  Even if g is a group leader and thus
can't exit before t, t or another sub-thread can exec and remove g from
the thread_group list.

The only lockless user of while_each_thread() is first_tid() and it is
fine in that it can't loop forever, yet for_each_thread() looks better and
I am going to change while_each_thread/next_thread.

Link: https://lkml.kernel.org/r/20230823170806.GA11724@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/base.c
include/linux/sched/signal.h