lib/stackdepot: off by one in depot_fetch_stack()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 23 Feb 2024 14:20:13 +0000 (17:20 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 5 Mar 2024 01:01:17 +0000 (17:01 -0800)
commitdc24559472a682eb124e869cb110e7a2fd857322
tree0dffd61a775e02d6037c755415c893b76f830405
parent9602e0ce981986acf03324e13fd65abefbe90e23
lib/stackdepot: off by one in depot_fetch_stack()

The stack_pools[] array has DEPOT_MAX_POOLS.  The "pools_num" tracks the
number of pools which are initialized.  See depot_init_pool() for more
details.

If pool_index == pools_num_cached, this will read one element beyond what
we want.  If not all the pools are initialized, then the pool will be
NULL, triggering a WARN(), and if they are all initialized it will read
one element beyond the end of the array.

Link: https://lkml.kernel.org/r/361ac881-60b7-471f-91e5-5bf8fe8042b2@moroto.mountain
Fixes: b29d31885814 ("lib/stackdepot: store free stack records in a freelist")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/stackdepot.c