s390/cio: Ensure the copied buf is NUL terminated
authorBui Quang Minh <minhquangbui99@gmail.com>
Wed, 24 Apr 2024 14:44:22 +0000 (21:44 +0700)
committerAlexander Gordeev <agordeev@linux.ibm.com>
Mon, 29 Apr 2024 17:21:34 +0000 (19:21 +0200)
commitda7c622cddd4fe36be69ca61e8c42e43cde94784
tree17c01faef1e00063164df065656374eba537f428
parentb961ec10b9f9719987470236feb50c967db5a652
s390/cio: Ensure the copied buf is NUL terminated

Currently, we allocate a lbuf-sized kernel buffer and copy lbuf from
userspace to that buffer. Later, we use scanf on this buffer but we don't
ensure that the string is terminated inside the buffer, this can lead to
OOB read when using scanf. Fix this issue by using memdup_user_nul instead.

Fixes: a4f17cc72671 ("s390/cio: add CRW inject functionality")
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20240424-fix-oob-read-v2-5-f1f1b53a10f4@gmail.com
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
drivers/s390/cio/cio_inject.c