ARM: dts: n900: remove mmc1 card detect gpio
authorMerlijn Wajer <merlijn@wizzup.org>
Tue, 30 Jun 2020 18:47:40 +0000 (11:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 08:19:51 +0000 (10:19 +0200)
commitda01c36dad868bf9c62e1c39e52b0ae1a848bded
tree58e96a581ec1b9a5a31535b951e557e44c00d0bb
parent7a485f9a4eb1c19cdc4abd38adb674e410495577
ARM: dts: n900: remove mmc1 card detect gpio

[ Upstream commit ed3e98e919aaaa47e9d9f8a40c3f6f4a22577842 ]

Instead, expose the key via the input framework, as SW_MACHINE_COVER

The chip-detect GPIO is actually detecting if the cover is closed.
Technically it's possible to use the SD card with open cover. The
only downside is risk of battery falling out and user being able
to physically remove the card.

The behaviour of SD card not being available when the device is
open is unexpected and creates more problems than it solves. There
is a high chance, that more people accidentally break their rootfs
by opening the case without physically removing the card.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Merlijn Wajer <merlijn@wizzup.org>
Link: https://lore.kernel.org/r/20200612125402.18393-3-merlijn@wizzup.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/omap3-n900.dts