net_sched: ets: fix a race in ets_qdisc_change()
authorEric Dumazet <edumazet@google.com>
Wed, 11 Jun 2025 11:15:14 +0000 (11:15 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Jun 2025 15:05:50 +0000 (08:05 -0700)
commitd92adacdd8c2960be856e0b82acc5b7c5395fddb
tree47f8d3e61bd87a9abe67ef44ad33a9ea3a87b2a3
parent43eb466041216d25dedaef1c383ad7bd89929cbc
net_sched: ets: fix a race in ets_qdisc_change()

Gerrard Tai reported a race condition in ETS, whenever SFQ perturb timer
fires at the wrong time.

The race is as follows:

CPU 0                                 CPU 1
[1]: lock root
[2]: qdisc_tree_flush_backlog()
[3]: unlock root
 |
 |                                    [5]: lock root
 |                                    [6]: rehash
 |                                    [7]: qdisc_tree_reduce_backlog()
 |
[4]: qdisc_put()

This can be abused to underflow a parent's qlen.

Calling qdisc_purge_queue() instead of qdisc_tree_flush_backlog()
should fix the race, because all packets will be purged from the qdisc
before releasing the lock.

Fixes: b05972f01e7d ("net: sched: tbf: don't call qdisc_put() while holding tree lock")
Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Suggested-by: Gerrard Tai <gerrard.tai@starlabs.sg>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250611111515.1983366-5-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_ets.c