net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access
authorDoug Berger <opendmb@gmail.com>
Thu, 25 Apr 2024 22:27:19 +0000 (15:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Apr 2024 05:24:21 +0000 (06:24 +0100)
commitd85cf67a339685beae1d0aee27b7f61da95455be
tree43f83f2b75f56ccec40b0e048a91a5df0fe5ed92
parentb2ff42c6d3abc26ef0f395fe9ee8c64364fbaa22
net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access

The EXT_RGMII_OOB_CTRL register can be written from different
contexts. It is predominantly written from the adjust_link
handler which is synchronized by the phydev->lock, but can
also be written from a different context when configuring the
mii in bcmgenet_mii_config().

The chances of contention are quite low, but it is conceivable
that adjust_link could occur during resume when WoL is enabled
so use the phydev->lock synchronizer in bcmgenet_mii_config()
to be sure.

Fixes: afe3f907d20f ("net: bcmgenet: power on MII block for all MII modes")
Cc: stable@vger.kernel.org
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmmii.c