selftests: drv-net: Make command requirements explicit
authorGal Pressman <gal@nvidia.com>
Wed, 23 Jul 2025 13:54:54 +0000 (16:54 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 25 Jul 2025 01:52:00 +0000 (18:52 -0700)
commitd74cd9a02f020a6263b12a4c9e0f846b679a2f13
tree7adb0312f74a1f10d5c5b79cf66f11664e52b997
parentb4d52c698210ae1a3ceb487b189701bc70551a48
selftests: drv-net: Make command requirements explicit

Make require_cmd() calls explicit about whether commands are needed
locally, remotely, or both.
Since require_cmd() defaults to local=True, tests should explicitly set
local=False when commands are only needed remotely.

- socat: Set local=False since it's only needed on remote hosts.
- iperf3: Use single call with both local=True and remote=True since
  it's needed on both hosts.

This avoids unnecessary test failures when commands are missing locally
but available remotely where actually needed, and consolidates a
duplicate require_cmd() call into single call that checks both hosts.

Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
Fixes: f1e68a1a4a40 ("selftests: drv-net: add require_XYZ() helpers for validating env")
Fixes: c76bab22e920 ("selftests: drv-net: rss_input_xfrm: Check test prerequisites before running")
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Link: https://patch.msgid.link/20250723135454.649342-3-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/hw/devlink_rate_tc_bw.py
tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py
tools/testing/selftests/drivers/net/hw/tso.py
tools/testing/selftests/drivers/net/lib/py/load.py
tools/testing/selftests/drivers/net/ping.py