bus: fsl-mc: fix double-free on mc_dev
authorIoana Ciornei <ioana.ciornei@nxp.com>
Tue, 8 Apr 2025 10:58:09 +0000 (13:58 +0300)
committerChristophe Leroy <christophe.leroy@csgroup.eu>
Mon, 12 May 2025 23:34:57 +0000 (01:34 +0200)
commitd694bf8a9acdbd061596f3e7549bc8cb70750a60
tree1a241a10f4b12062672dcb878abe053ec4fe8451
parent617a7ed073115016e417b518c68c96057f1bf66c
bus: fsl-mc: fix double-free on mc_dev

The blamed commit tried to simplify how the deallocations are done but,
in the process, introduced a double-free on the mc_dev variable.

In case the MC device is a DPRC, a new mc_bus is allocated and the
mc_dev variable is just a reference to one of its fields. In this
circumstance, on the error path only the mc_bus should be freed.

This commit introduces back the following checkpatch warning which is a
false-positive.

WARNING: kfree(NULL) is safe and this check is probably not required
+       if (mc_bus)
+               kfree(mc_bus);

Fixes: a042fbed0290 ("staging: fsl-mc: simplify couple of deallocations")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20250408105814.2837951-2-ioana.ciornei@nxp.com
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
drivers/bus/fsl-mc/fsl-mc-bus.c